Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions block added #236

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Transactions block added #236

merged 6 commits into from
Jun 3, 2024

Conversation

jindaliiita
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #158

Test URLs:

Copy link

aem-code-sync bot commented May 22, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented May 22, 2024

Page Scores Audits Google
/drafts/piyush/transactions-block PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to closed-transaction May 23, 2024 09:20 Inactive
Copy link
Collaborator

@bstopp bstopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block name needs to be more specific -

blocks/transactions/transactions.css Outdated Show resolved Hide resolved
blocks/transactions/transactions.css Outdated Show resolved Hide resolved
blocks/transactions/transactions.css Outdated Show resolved Hide resolved
@jindaliiita jindaliiita force-pushed the closed-transaction branch from b683128 to d6315fd Compare May 24, 2024 07:39
@aem-code-sync aem-code-sync bot temporarily deployed to closed-transaction May 24, 2024 07:40 Inactive
@jindaliiita jindaliiita requested a review from bstopp May 24, 2024 07:40
@jindaliiita jindaliiita force-pushed the closed-transaction branch from 90d0bf3 to 1820c30 Compare May 27, 2024 04:19
@aem-code-sync aem-code-sync bot temporarily deployed to closed-transaction May 27, 2024 04:19 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to closed-transaction May 27, 2024 04:19 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to closed-transaction May 30, 2024 14:49 Inactive
@jindaliiita jindaliiita force-pushed the closed-transaction branch from e64f732 to 919b58c Compare June 3, 2024 15:07
@aem-code-sync aem-code-sync bot temporarily deployed to closed-transaction June 3, 2024 15:07 Inactive
@jindaliiita jindaliiita merged commit 695d51a into main Jun 3, 2024
2 checks passed
@bstopp bstopp deleted the closed-transaction branch June 17, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent Template - Closed Transactions list
2 participants